This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix comment typos in std_valarray.h
Volker Reichelt wrote:
> On 27 Jul, Jonathan Wakely wrote:
> > The original is fine, Gaby's version is fine, but Volker's is not good
> > English. You never say "A has not B" in English, you say "A does not
> > have B."
>
> Of course. Stupid me. Sorry!
I don't remember where, but exactly this oddity of English came up on
another list recently - I think it's fair to say it's English's
"typename" ;)
> > FWIW the standard talks about lengths, not sizes, e.g.
> > "The resulting behavior is undefined if the length of the argument array
> > is not equal to the length of the *this array."
>
> OTOH you call size() to get the length :-)
Good point!
> Thanks for the thorough review.
>
> Ok, here's an updated version.
That all looks good to me.
> Is this OK for mainline?
>
> Should I add you, Jon, to the ChangeLog?
I don't think I deserve that. I can't help being pedantic about English,
so feel free to use me for grammar checking :)
jon