This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] profopt.exp and remote testing
- From: Adam Nemet <anemet at lnxw dot com>
- To: Geoff Keating <geoffk at apple dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, janis187 at us dot ibm dot com
- Date: Mon, 25 Jul 2005 12:15:07 -0700
- Subject: Re: [PATCH] profopt.exp and remote testing
- References: <A9E7DCB4-5253-4EE4-899D-B73B058E2BE4@apple.com>
Geoff Keating writes:
>> 2003-03-23 Adam Nemet <anemet at lnxw dot com>
>>
>> * lib/profopt.exp (profopt-execute): Check for profiling data
>> files on the target.
>
> This is OK.
Thanks Geoff. It's been two years so the patch no longer applies.
This is what I've just committed. It still fixes the still broken
cross testing. I re-regtested it on i686-pc-linux-gnu.
2005-07-25 Adam Nemet <anemet@lnxw.com>
* lib/profopt.exp (profopt-execute): Check for profiling data
files on the target.
Index: profopt.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/profopt.exp,v
retrieving revision 1.9
diff -u -p -r1.9 profopt.exp
--- profopt.exp 25 Jun 2005 01:45:23 -0000 1.9
+++ profopt.exp 25 Jul 2005 07:02:46 -0000
@@ -231,6 +231,8 @@ proc profopt-execute { src } {
}
set executable $tmpdir/[file tail [file rootname $src].x]
+ set basename [file tail $testcase]
+ set base [file rootname $basename]
set count 0
foreach option $prof_option_list {
@@ -245,7 +247,9 @@ proc profopt-execute { src } {
verbose "Testing $testcase, $option" 1
# Remove old profiling and performance data files.
- profopt-cleanup $testcase $prof_ext
+ foreach ext $prof_ext {
+ remote_file target delete $tmpdir/$base.$ext
+ }
if [info exists perf_ext] {
profopt-cleanup $testcase $perf_ext
}
@@ -282,9 +286,8 @@ proc profopt-execute { src } {
set missing_file 0
# Make sure the profile data was generated, and fail if not.
if { $status == "pass" } {
- set basename [file tail $testcase]
- set base [file rootname $basename]
foreach ext $prof_ext {
+ remote_upload target $tmpdir/$base.$ext
set files [glob -nocomplain $base.$ext]
if { $files == "" } {
set status "fail"
@@ -335,7 +338,9 @@ proc profopt-execute { src } {
}
# Remove the profiling data files.
- profopt-cleanup $testcase $prof_ext
+ foreach ext $prof_ext {
+ remote_file target delete $tmpdir/$base.$ext
+ }
if { $status != "pass" } {
continue