This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ipa-inline.c cleanups


> > 
> > P.S. Note unrelated to your patch, I noticed this nicety:
> > "int badness = cgraph_estimate_growth (edge->callee) * 256;".  This
> > is going to be fun with very large functions (e.g. 2GB and up, like
> > those supported in the large code model of the AMD64 ABI).  Honza,
> > is this overflow-safe??
> 
> Sort-of, we won't consider them inline candidates...
And of course we won't support 2GB functions and up anytime soon as on
many places we assume number of insns/basic blocks or basic blocks *
registers or number of alias sets or whatever fits in integer...
So unless we come up with region based compilation and get very cureful
about this issues, this won't happen.

We plan to add large model support soon, but only to allow >2GB text
segment as a whole, not in single function body or GCC produced object
file.

Honza
> 
> Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]