This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, fortran] Simplify constant substrings

From: Paul Brook <paul at codesourcery dot com>
To: fortran at gcc dot gnu dot org
Cc: David Edelsohn <dje at watson dot ibm dot com>,Steven Bosscher <steven at gcc dot gnu dot org>,Andreas Jaeger <aj at suse dot de>,gcc-patches at gcc dot gnu dot org
Date: Fri, 22 Jul 2005 15:35:12 +0100
Subject: Re: [PATCH, fortran] Simplify constant substrings
References: <200507220453.j6M4rCd26890@makai.watson.ibm.com> <200507221527.44470.steven@gcc.gnu.org> <200507221344.j6MDicd26372@makai.watson.ibm.com>

On Friday 22 July 2005 14:44, David Edelsohn wrote:
> >>
> >> Who implied that it would not?
>
> Steven> Your patch didn't and you didn't say you planned to add it to the
> Steven> test suite.  Nobody can read your mind, you know.
>
> 	Testcases for patches are added to the testsuite.  That is a
> general policy.

We also require that all patches are properly tested, and it is convention to 
add ChangeLog entries for new testcases.

Your original submission did not mention either of these things. As an 
experienced gcc contributor you should know to include this information.

Paul

Follow-Ups:
- Re: [PATCH, fortran] Simplify constant substrings
  - From: David Edelsohn
- Re: [PATCH, fortran] Simplify constant substrings
  - From: Daniel Berlin

References:
- [PATCH, fortran] Simplify constant substrings
  - From: David Edelsohn
- Re: [PATCH, fortran] Simplify constant substrings
  - From: Steven Bosscher
- Re: [PATCH, fortran] Simplify constant substrings
  - From: David Edelsohn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]