This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH PING ^2] Make CONSTRUCTOR use VEC


Andrew Haley <aph@redhat.com> wrote:

>  > Make CONSTRUCTOR use VEC
>  > http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00647.html
>  >
>  > Reviews by FE maintainers for changes in the FE-specific bits are
>  > appreciated (especially C and Java). C++ and Fortran are already
>  > approved.
>
> The Java parts look straightforward enough, so I have no complains
> there.  But in several places you've exceeded max line length and
> changed layout to non-GNU form.

Thanks. I double checked the java bits and I found one line of 81 chars, and
indentation problems with do-while brackets in java-tree.h. The rest looks
already in GNU form to me, unless I'm missing some indentation rule.
-- 
Giovanni Bajo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]