This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libgfortran] Fix PR21875 (FM111.f) BN and BZ format specifiers
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, patch <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 9 Jul 2005 13:25:54 -0700
- Subject: Re: [PATCH, libgfortran] Fix PR21875 (FM111.f) BN and BZ format specifiers
- References: <42CF78B9.3060908@verizon.net> <42CF8367.70002@verizon.net> <42D02E27.1070501@verizon.net>
On Sat, Jul 09, 2005 at 01:05:59PM -0700, Jerry DeLisle wrote:
> OK This looks better now.
>
> This updated patch and test case bubblestrapped and regtested on
> i686-pc-linux-gnu.
>
> 2005-07-09 Jerry DeLisle <jvdelisle@verizon.net>
>
> PR libfortran/21875 (FM111.f)
> * io/read.c (next_char): Return a ' ' character when BLANK_ZERO or
> BLANK_NULL are active.
> (read_decimal): Interpret ' ' character correctly for BZ or BN.
> (read_radix): Interpret ' ' character correctly for BZ or BN.
> (read_f): Interpret ' ' character correctly for BZ or BN.
> * gfortran.dg/test (fmt_read_bz_bn.f90): New test case.
>
>
> NIST FM111.f retested OK.
>
> Renamed and fixed the test case.
>
> OK to commit?
>
This is ok, but please check your diff for whitespace changes
(ie., tabs becoming spaces). For example, your diff shows
*************** read_decimal (fnode * f, char *dest, int
*** 348,354 ****
if (value > maxv - c)
goto overflow;
! value += c;
}
v = value;
--- 354,360 ----
if (value > maxv - c)
goto overflow;
! value += c;
}
v = value;
--
Steve