This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add leafify attribute as hint for inlining
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 08 Jul 2005 17:52:45 -0700
- Subject: Re: [PATCH] Add leafify attribute as hint for inlining
- References: <Pine.LNX.4.58.0507071856500.9561@wotan.suse.de>
Richard Guenther wrote:
This is an update to the leafify attribute patch for mainline.
It still does what it did, it is still useful for me. So I thought
posting it before stage3 again.
Thanks for persisting. I think this patch is good.
+ { "leafify", 0, 0, true, false, false,
+ handle_leafify_attribute },
I'm not a fan of made-up words. How about "inline_callees"?
+ if (TREE_CODE (*node) == FUNCTION_DECL)
+ {
+ /* Do nothing else, just set the attribute. We'll get at
+ it later with lookup_attribute. */
+ }
The usual style is just:
if (...)
/* ... */
;
else
rather than the empty braces.
With those changes, and the other changes that were recommended to the
test case, and to rely on Kenny's changes, I'm sure this will be OK for
4.1. Please ask me for a review when you've updated, and I'll
review/approve the patch.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304