Re: [PATCH] Fix type mismatch created by DOM (PR 22335)

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Jul 8, 2005, at 3:18 PM, Richard Henderson wrote:

> On Fri, Jul 08, 2005 at 03:11:40PM -0400, Andrew Pinski wrote:
> > There are two issues here, the first is in lookup_avail_expr dealing
> > 	* tree-ssa-dom.c (lookup_avail_expr): Use constant_boolean_node
> > 	instead	of boolean_false_node/boolean_true_node.
>
> This part is ok.
>
> > 	(eliminate_redundant_computations): Convert the cached_lhs to the
> > 	correct type if needed.
>
> I havn't looked at this to see whether it's valid to propagate
> something that may include a NOP_EXPR.  Do you have any argument
> to say that it is?

What about this patch, which I am currently bootstrapping which only do 
this
for a MODIFY_EXPR.  We only replace it into right hand side of 
MODIFY_EXPR,
COND_EXPR, and SWITCH_EXPR.  We don't need to convert the one in switch
statement, or conditional statements.

Thanks,
Andrew Pinski

Attachment: t1.diff.txt
Description: Text document

ChangeLog:
	* tree-ssa-dom.c (eliminate_redundant_computations): Convert the 
cached_lhs
	to the correct type if needed and in a MODIFY_EXPR.