This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Committed] re: Enable Hollerith constant and character arrayin format tag (take 3).
- From: Steven Bosscher <stevenb at suse dot de>
- To: Feng Wang <wf_cs at yahoo dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Jul 2005 13:31:25 +0200
- Subject: Re: [Patch, Committed] re: Enable Hollerith constant and character arrayin format tag (take 3).
- References: <20050707080745.34589.qmail@web15610.mail.cnb.yahoo.com>
On Thursday 07 July 2005 10:07, Feng Wang wrote:
> Tested on ia64 and i686 linux. Commited on GCC 4.1
>
> The diff file is attached.
Next time please bootstrap your changes. You broke it now:
../../mainline/gcc/fortran/primary.c: In function 'match_hollerith_constant':
../../mainline/gcc/fortran/primary.c:254: warning: pointer targets in passing argument 2 of 'gfc_extract_int' differ in signedness
make[2]: *** [fortran/primary.o] Error 1
* primary.c (match_hollerith_constant): Use int, not unsigned int,
for the hollerith length. Fix indentation.
Index: primary.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fortran/primary.c,v
retrieving revision 1.29
diff -u -3 -p -r1.29 primary.c
--- primary.c 7 Jul 2005 07:54:42 -0000 1.29
+++ primary.c 7 Jul 2005 11:30:26 -0000
@@ -237,8 +237,8 @@ match_hollerith_constant (gfc_expr ** re
gfc_expr * e = NULL;
const char * msg;
char * buffer;
- unsigned int num;
- unsigned int i;
+ int num;
+ int i;
old_loc = gfc_current_locus;
gfc_gobble_whitespace ();
@@ -271,7 +271,7 @@ match_hollerith_constant (gfc_expr ** re
}
else
{
- buffer = (char *)gfc_getmem (sizeof(char)*num+1);
+ buffer = (char *) gfc_getmem (sizeof(char) * num + 1);
for (i = 0; i < num; i++)
{
buffer[i] = gfc_next_char_literal (1);