Re: [patch] Externalize data-ref analysis - part 1

[Daniel Berlin <dberlin at dberlin dot org>]

On Tue, 2005-06-28 at 14:49 +0300, Ira Rosen wrote:
> 
> 
> 
> This is the first part - of generalization/externalization data-ref
> analysis from the vectorizer.


Hi Ira:

I have two overall comments on this patch that i'd like to see
addressed	

1. Correct me if i'm wrong, but it looks like some fields are valid on
array references but not pointer references, and vice versa.

If this is true, we should probably add an enum to tell what kind of
reference something is (pointer or array), instead of checking whether
certain fields are null, etc.  This would also enable us to make sure
nobody is trying to use fields on pointer references or array references
that are not valid.

2. You added an alignment parameter to find_data_references_in_loop and
downward, but it's not documented in find_data_references_in_loop.

It's also very unclear what it is.
The only docs in the lower functions is "The required alignment in
bytes".
Required for what, exactly?

If this is information about what the vectorizer requires in terms of
alignment for a given loop, that should not be passed to this generic
function. *That* part (and whatever misalignment info it needs) should
be computed separately by the vectorizer.

--Dan