This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Remove var_ann->uid


On Wed, 2005-06-29 at 21:28 -0400, Diego Novillo wrote:
> On Wed, Jun 29, 2005 at 10:23:42AM -0400, Daniel Berlin wrote:
> 
> > 2005-06-29  Daniel Berlin  <dberlin@dberlin.org>
> > 
> > 	* tree-complex.c (complex_variable_components): Now a hashtable.
> >	[ ... ]
> >
> OK once the libiberty changes are approved.
> 
> Just to be on the safe side, would you mind testing on a 64bit
> host sufficiently different from x86 to rule out any hashing bugs
> and whatnot?  Thanks.

Sure.
I'll throw it on my ppc64.

One thing Kenny pointed out to me privately, is that it's probably
faster to just reuse the aux field instead of hashtabling the
used_portions/complex_variable stuff, since it isn't persistent data.

If you like that more, I'll go that route and remove the extra
hashtables (either now or as a followup, either way is fine).

--Dan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]