Re: [patch] Fix PR c++/15759: Function pointers in default arguments

[Mark Mitchell <mark at codesourcery dot com>]

Gabriel Dos Reis wrote:
> Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:
>
> | >> ===================================================================
> | >> --- gcc/gcc/cp/tree.c	15 Jun 2005 00:41:34 -0000	1.437
> | >> +++ gcc/gcc/cp/tree.c	16 Jun 2005 16:58:47 -0000
> | >> @@ -1181,7 +1181,12 @@ bot_manip (tree* tp, int* walk_subtrees,
> | >>        return NULL_TREE;
> | >>      }
> | >>    else if (TREE_CODE (t) == CALL_EXPR)
> | >> -    mark_used (TREE_OPERAND (TREE_OPERAND (t, 0), 0));
> | >> +    {
> | >> +      t = TREE_OPERAND (t, 0);
> | >> +      if (TREE_CODE (t) == CONVERT_EXPR)
> | >> +        t = TREE_OPERAND (t, 0);
> | >> +      mark_used (t);
> | >> +    }
>
>
> Please add a comment.

This change doesn't look right to me.

I think default arguments should be ignored from within bot_manip.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304