This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Always create target tools in the gcc directory, take 6 (Re: [PATCH] gcc configure's determination of ld and as)
Paolo Bonzini wrote:
I presume this patch was not tested with a one-tree cross build,
without any installed target tools, and with configure earlier
yielding:
Indeed I always tried it with tools available, either in-tree or in the
file system.
The dependency is useless unless the tools are in tree.
No, I am really stupid if the attached patch fixes it, and I should have
read twice more the documentation for AC_PATH_PROGS (which always
overwrite the user's previous setting).
I had the in-tree tools, but somehow I brought the test out of the `if'
and the in-tree tools were not detected anymore.
Can you try it? For arm-elf and arm-symbianelf it gets me a lot farther
than earlier (libstdc++).
Richard, I am CCing you because the patch is simple, it affected you,
and you are a GWP person.
Paolo
2005-06-17 Paolo Bonzini <bonzini@gnu.org>
* aclocal.m4 (gcc_AC_CHECK_TOOL): Do not overwrite the
passed variable.
Index: aclocal.m4
===================================================================
RCS file: /cvs/gcc/gcc/gcc/aclocal.m4,v
retrieving revision 1.106
diff -p -u -r1.106 aclocal.m4
--- aclocal.m4 16 Jun 2005 12:48:44 -0000 1.106
+++ aclocal.m4 17 Jun 2005 10:21:45 -0000
@@ -710,7 +710,9 @@ AC_REQUIRE([gcc_AC_BUILD_EXEEXT])
dnl shut up useless "checking for..." messages
dnl we can still read them in config.log
exec AS_MESSAGE_FD([])>/dev/null
-AC_PATH_PROGS($1, $2, , $gcc_cv_tool_dirs)
+if test "x[$]$1" = x; then
+ AC_PATH_PROGS($1, $2, , $gcc_cv_tool_dirs)
+fi
if test "x[$]$1" = x; then
# If the loop above did not find a tool, then use whatever
# one we can find in the users's path. We are looking for a