This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran,patch]Enable Hollerith constant and character arrayin format tag (2nd).
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Feng Wang <fengwang at nudt dot edu dot cn>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org,Steven Bosscher <stevenb at suse dot de>, Richard Henderson <rth at redhat dot com>
- Date: Fri, 10 Jun 2005 19:38:50 +0200
- Subject: Re: [fortran,patch]Enable Hollerith constant and character arrayin format tag (2nd).
- References: <20050524161808.083D05CFCD@ds20.nudt.edu.cn>
Feng Wang wrote:
> I rewrite the patch I posted on:
> http://gcc.gnu.org/ml/fortran/2005-03/msg00502.html
Steven commented on your original patch, so I hoped he would comment on the
revised version as well. Steven, are you reviewing this patch?
One comment I'm having is this: if there was a way to convert from the
hollerith strings to mpfr / mpz that correctly deals with target precision,
then this patch could be simplified, as all the special case that deal with
constant coming from hollerith constants could be done away with. Since this
would be not different from a mechanism for converting from the target's
binary representation to mpfr / mpz, this functionality would also be helpful
for the transition of gcc's internal arithmetic to mpfr which rth has argued
for at different occasions in the past, so this might indeed be something
worthwhile to pursue. That's not a demand that can be put on your patch, though.
- Tobi