Re: PATCH to read-rtl.c

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

Andrew Pinski <pinskia@physics.uc.edu> writes:

| On Jun 9, 2005, at 2:49 PM, Gabriel Dos Reis wrote:
| 
| > | really
| > | the only thing which should be changed instead are the .h files to
| > | support C++ source files,
| >
| > May I remind you that, the current state of the .c sources violates
| > our own coding convention and therefore needs conversion?
| 
| Which part is violating what and where is this coding convention
| documented because I don't see it?

   Avoid the use of identifiers or idioms that would prevent code
   compiling with a C++ compiler. Identifiers such as new or class,
   that are reserved words in C++, should not be used as variables or
   field names. Explicit casts should be used to convert between void*
   and other pointer types.

Are we going through this debate again, Andrew?  You don't think
everything has been said?


-- Gaby