This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to read-rtl.c
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 Jun 2005 13:01:10 -0400
- Subject: Re: PATCH to read-rtl.c
- References: <m3ekbbsapy.fsf@uniton.integrable-solutions.net>
On Jun 9, 2005, at 1:26 PM, Gabriel Dos Reis wrote:
Hi,
This patchlet converts gcc/read-rtl.c to the common subset of C and
C++.
The issues here mostly have to do with the implicit conversion
integer -> enumerations. I post it seperately only to explain the
"extreme" case of mechanical conversion involved.
I don't like this. I don't understand you are converting the .c files,
really
the only thing which should be changed instead are the .h files to
support
C++ source files, any thing else is really extreme and stupid at this
moment
and makes me want to cry as int to enum is perfectly legal C and I hate
too much clutter like you are adding to the source.
-- Pinski