Re: PR testsuite/20772 - further pieces

[Andreas Jaeger <aj at suse dot de>]

Janis Johnson <janis187@us.ibm.com> writes:

> On Thu, May 26, 2005 at 11:19:14PM +0200, Andreas Jaeger wrote:
>> Janis Johnson <janis187@us.ibm.com> writes:
>> 
>> > On Thu, May 26, 2005 at 09:15:10PM +0200, Andreas Jaeger wrote:
>> >> Index: i386-sse-8.c
>> >> ===================================================================
>> >> RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/i386-sse-8.c,v
>> >> retrieving revision 1.7
>> >> diff -u -p -r1.7 i386-sse-8.c
>> >> --- i386-sse-8.c	17 Nov 2004 17:21:45 -0000	1.7
>> >> +++ i386-sse-8.c	26 May 2005 17:44:07 -0000
>> >> @@ -4,8 +4,8 @@
>> >>  /* The xstormy16 doesn't support V2DI.  */
>> >>  /* { dg-do compile { xfail xstormy16-*-* } } */
>> >>  /* { dg-options "" } */
>> >> -/* { dg-options "-march=pentium3" { target i?86-*-* } } */
>> >> -/* { dg-skip-if "" { i?86-*-* } { "-m64" } { "" } } */
>> >> +/* { dg-options "-march=pentium3" { target i?86-*-* x86_64-*-* } } */
>> >> +/* { dg-require-effective-target ilp32 } */
>> >
>> > The test is for a problem using SSE, so when compiling for ilp32 x86 it
>> > should probably use "-march-pentium3 -msse" (or is -msse implied for
>> > -march=pentium3?).  Without those options the test will use generic
>> > vectors and presumably shouldn't fail anywhere.
>> 
>> I just checked - this looks fine, -march=pentium3 allows the usage of
>> SSE registers.  So, I'm not going to change this.
>
> It shouldn't need "dg-require-effective-target ilp32", since everything
> besides x86 ilp32 can use generic vectors.  Leaving that in your patch
> will cause this test to be skipped for targets that are currently using
> it.

I do not agree, the bug only occured with -march=pentium3 - and not
-march=pentium4.  Both imply SSE.  For x86_64 -march=pentium3 is not a
valid architecture, so I have to ask for x86 ilp32,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature