This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Janis Johnson <janis187@us.ibm.com> writes: > On Thu, May 26, 2005 at 09:15:10PM +0200, Andreas Jaeger wrote: >> >> This fixes the issues in g++.old-deja and gcc.dg that I noticed where >> we were not running the testsuite on Linux/x86-64 with -m32 or tested >> something slightly different. >> >> Tested on Linux/x86-64 with and without -m32. >> >> Ok to commit? > > Yes, with a couple of changes noted below. > >> Index: 20011119-1.c >> >> +/* { dg-skip-if "" { "" } { "-fpic" "-fPIC" } { "" } } */ > ^ > This doesn't work; use "*-*-*" to match all targets. Ok. >> Index: i386-sse-8.c >> =================================================================== >> RCS file: /cvs/gcc/gcc/gcc/testsuite/gcc.dg/i386-sse-8.c,v >> retrieving revision 1.7 >> diff -u -p -r1.7 i386-sse-8.c >> --- i386-sse-8.c 17 Nov 2004 17:21:45 -0000 1.7 >> +++ i386-sse-8.c 26 May 2005 17:44:07 -0000 >> @@ -4,8 +4,8 @@ >> /* The xstormy16 doesn't support V2DI. */ >> /* { dg-do compile { xfail xstormy16-*-* } } */ >> /* { dg-options "" } */ >> -/* { dg-options "-march=pentium3" { target i?86-*-* } } */ >> -/* { dg-skip-if "" { i?86-*-* } { "-m64" } { "" } } */ >> +/* { dg-options "-march=pentium3" { target i?86-*-* x86_64-*-* } } */ >> +/* { dg-require-effective-target ilp32 } */ > > The test is for a problem using SSE, so when compiling for ilp32 x86 it > should probably use "-march-pentium3 -msse" (or is -msse implied for > -march=pentium3?). Without those options the test will use generic > vectors and presumably shouldn't fail anywhere. I just checked - this looks fine, -march=pentium3 allows the usage of SSE registers. So, I'm not going to change this. > I'd use: > > /* { dg-options "-march=pentium3 -msse" { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */ Didn't know that I could do it this way - will do for my next patches ;-) > BTW, the test should reference PR 14343, not 14313. OK, fixed. Thanks for the review, Andreas -- Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Attachment:
pgp00000.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |