Re: [patch] MIPS: add mips32r2 patterns to generate ext and ins insns.

[Nigel Stephens <nigel at mips dot com>]

David Ung wrote:

> + bool
> + mips_use_ins_ext_p (rtx op, rtx size, rtx position)
> + {
> +   HOST_WIDE_INT len, pos;
> + 
> +   if (!ISA_HAS_EXT_INS
> +       || !register_operand (op, VOIDmode))
> +     return false;
> + 
> +   len = INTVAL (size);
> +   pos = INTVAL (position);
> +   
> +   if (len <= 0 || len >= BITS_PER_WORD || pos < 0
> +       || pos + len > BITS_PER_WORD)
> +     return false;
> + 
>  

Looking at this go past, I wonder should that test be using
GET_MODE_BITSIZE (GET_MODE (op)) rather than BITS_PER_WORD?

Nigel