Re: [patch] MIPS: add mips32r2 patterns to generate ext and insinsns.

[David Ung <davidu at mips dot com>]

>   (a) I said in the review that the extzv<mode> and insv<mode> patterns
>       should use the "mips_use_ins_ext_p" function as their condition,
>       because that would stop the optimisers from creating their own
>       invalid patterns (through combination, etc.)  I notice that you've
>       decided to just use ISA_HAS_EXT_INS instead.

ah..  I miss that one.   ok.

> 
>   (b) I said in the second message that you should remove the TARGET_64BIT
>       check from code like this:

I think I must of miss-read your mail.  I thought your were refering to
the TARGET_64BIT check for the original extvdi and insvdi patterns.
I'll remove them from the expander.

David.