This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] PR libfortran/21376


you
should add a testcase for it, though.  The testcase I posted is not good
enough given that I got the exponents of the corner cases wrong.

There can is no easy testcase for this PR. In fact, there are already cases in the testsuite where we compute the format of 1.0, but the PR only fails if some external C code modifies the FPU flags to issue FPE in such a case.


So, I don't think this can be done in a portable way (and using the dejagnu framework).

Another issue is that your patch is only superficially different from the one
Peter Wainwright suggested when he filed the PR, so you should probably add
his name to the ChangeLog entry.

Committed:


Index: libgfortran/ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/ChangeLog,v
retrieving revision 1.227
diff -p -u -r1.227 ChangeLog
--- libgfortran/ChangeLog       22 May 2005 21:17:41 -0000      1.227
+++ libgfortran/ChangeLog       24 May 2005 20:43:28 -0000
@@ -1,4 +1,4 @@
-2005-05-22  Francois-Xavier Coudert  <coudert@clipper.ens.fr>
+2005-05-22  Peter Wainwright  <prw@ceiriog1.demon.co.uk>

        PR libfortran/21376
        * io/write.c (output_float): Rework logic to avoid call to log10


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]