This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix for "FAIL: g++.jason/thunk3.C" in gcc testsuite
Nick Clifton <nickc@redhat.com> writes:
>>> Approved and applied, although I changes the string to be "m32r-*"
>>> since on my test system I check against an "m32r-sim" target.
>
>> Did you test that change?
>
> Yes
>
>> I thought the target selector had to have
>> three components.
>
> No.
>
>> Hmm... I just updated and tried running the test. I get:
>> ERROR: g++.old-deja/g++.jason/thunk3.C: syntax error in target
>> selector "xfail rs6000-*-* powerpc-*-eabi m68k-*-coff mn10300-*-*
>> v850-*-* sh-*-* sh64-*-* h8*-*-* xtensa-*-* m32r*-*" for " dg-do 1 run
>> { xfail rs6000-*-* powerpc-*-eabi m68k-*-coff mn10300-*-* v850-*-*
>> sh-*-* sh64-*-* h8*-*-* xtensa-*-* m32r*-* } "
______________________________________^^^^^^^
>
> True - my email was incorrect. I changed the string from m32r*-*-* to
> m32r*-*. The important point was the presence of only one dash.
It sounds like you might have misread my message. I got that error
after running "cvs update" to pull in your change. As you can see,
the message is complaining about "m32r*-*".
The point is that target selectors work on the _canonical_ target
name, not the target alias. So if you're testing --target=mips-elf,
the target selector will match the canonical target (mips-unknown-elf),
not the shortened form. The same would go for "m32r-sim" as well.
In summary, I think Kazuhiro's patch was correct as posted.
Richard