This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Remove TARGET_SWITCHES from the SH port
Alexandre Oliva <aoliva@redhat.com> writes:
> On May 15, 2005, Richard Sandiford <rsandifo@redhat.com> wrote:
>> Also, superh.h and superh64.h define something called
>> TARGET_PROCESSOR_SWITCHES. This macro doesn't seem to be used
>> anywhere, and as far as I can tell, the headers themselves aren't
>> included by any configuration. The patch simply deletes them.
>> Is that OK?
>
> I'll leave that for Joern to explain. I didn't know about these
> headers myself.
OK, I'll wait until Joern says either way.
> The rest looks good to me.
Great! Thanks for the review.
>> +;; ??? This option is not useful, but is retained in case there are people
>> +;; who are still relying on it. It may be deleted in the future. */
>> +mpadstruct
>
> You may want to drop the `*/' at the end of the comment above.
Argh! Well spotted. I see there were a couple of other typos too.
First in the message itself:
-------------------------------------------------------------------------
(b) Overriding options.h's TARGET_SH4 with a definition that
checks !TARGET_SH1.
-------------------------------------------------------------------------
which should have said "TARGET_SH1". Also, there were a couple
of bogus *_BIT->MASK_* changes:
-------------------------------------------------------------------------
@@ -5236,7 +5348,7 @@ calc_live_regs (HARD_REG_SET *live_regs_
CLEAR_HARD_REG_SET (*live_regs_mask);
if ((TARGET_SH4 || TARGET_SH2A_DOUBLE) && TARGET_FMOVD && interrupt_handler
&& regs_ever_live[FPSCR_REG])
- target_flags &= ~FPU_SINGLE_BIT;
+ target_flags &= MASK_FPU_SINGLE;
/* If we can save a lot of saves by switching to double mode, do that. */
else if ((TARGET_SH4 || TARGET_SH2A_DOUBLE) && TARGET_FMOVD && TARGET_FPU_SINGLE)
for (count = 0, reg = FIRST_FP_REG; reg <= LAST_FP_REG; reg += 2)
@@ -5245,7 +5357,7 @@ calc_live_regs (HARD_REG_SET *live_regs_
|| (interrupt_handler && ! pragma_trapa))
&& ++count > 2)
{
- target_flags &= ~FPU_SINGLE_BIT;
+ target_flags &= MASK_FPU_SINGLE;
break;
}
/* PR_MEDIA_REG is a general purpose register, thus global_alloc already
-------------------------------------------------------------------------
Fixed in my local copy. I obviously did this too late at night, sorry...
Richard