This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR target/19933 and PR target/21315

Eric Botcazou wrote: 
But equally __GNUC__ could appear elsewhere as part of a proper
conditioning of the definitions.

#if __GNUC__ >= 4
#define __have_somthing
#endif
...

#ifdef __have_something
...
#endif


What are you concerned about, exactly? That we still fix the Sun version when there is already a GCC version (harmless)

I'm not sure I understand what you're asking, but I think you're saying that if the header already has GCC support it's harmless to fix it. That's not true; unnecessary fixes get in the way every time someone updates the system headers. We should be fixing only those headers for which we absolutely must.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]