This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR target/19933 and PR target/21315

From: Eric Botcazou <ebotcazou at libertysurf dot fr>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org,Bruce <bkorb at gnu dot org>,Mark Mitchell <mark at codesourcery dot com>
Date: Thu, 12 May 2005 18:16:09 +0200
Subject: Re: [PATCH] Fix PR target/19933 and PR target/21315
References: <200505121514.03992.ebotcazou@libertysurf.fr> <200505121616.17954.ebotcazou@libertysurf.fr> <Pine.LNX.4.61.0505121530070.2680@digraph.polyomino.org.uk>

> But equally __GNUC__ could appear elsewhere as part of a proper
> conditioning of the definitions.
>
> #if __GNUC__ >= 4
> #define __have_somthing
> #endif
> ...
>
> #ifdef __have_something
> ...
> #endif

What are you concerned about, exactly?  That we still fix the Sun version when 
there is already a GCC version (harmless) or that we fix the GCC version 
(wrong).  In the former case I don't see the problem, in the latter case I'm 
under the impression the solution is to strengthen the matching regexp, not 
to loosen the bypass regexp.

-- 
Eric Botcazou

Follow-Ups:
- Re: [PATCH] Fix PR target/19933 and PR target/21315
  - From: Mark Mitchell

References:
- [PATCH] Fix PR target/19933 and PR target/21315
  - From: Eric Botcazou
- Re: [PATCH] Fix PR target/19933 and PR target/21315
  - From: Eric Botcazou
- Re: [PATCH] Fix PR target/19933 and PR target/21315
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]