This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] patch PR 20788
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: François-Xavier Coudert <Francois-Xavier dot Coudert at lcp dot u-psud dot fr>
- Cc: gfortran <fortran at gcc dot gnu dot org>, patch <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 09 May 2005 20:43:08 +0200
- Subject: Re: [gfortran] patch PR 20788
- References: <4275DAFC.30101@lcp.u-psud.fr>
François-Xavier Coudert wrote:
> Regtested on i386-linux. OK for mainline and 4.0?
>
>
> ------------------------------------------------------------------------
>
> 2005-05-02 Francois-Xavier Coudert <coudert@clipper.ens.fr>
>
> PR libfortran/20788
> * io/unix.c (fd_to_stream): Add an avoid_mmap argument indicating
> we don't we to mmap this stream. Use fd_open instead of mmap_open
> in that case.
> (open_external): Call fd_to_stream with avoid_mmap = 0.
> (input_stream): Call fd_to_stream with avoid_mmap = 1.
> (output_stream): Likewise.
> (error_stream): Likewise.
>
Steve's "whoops" mail reminded me that I hadn't yet answered to this mail.
I think it's pointless to add avoid_mmap to fd_to_stream's interface, and
would prefer if you explicitly checked for the affected three units in that
function. Or is it likely that there will be other cases where this is necessary?
The patch is of course correct, and you can leave it installed if you don't
agree with me.
- Tobi