This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for bugs 772 and 17913


Gábor Lóki wrote:
Roger Sayle wrote:

-  if (TREE_CODE (ifexp) == INTEGER_CST)
-    return non_lvalue (integer_zerop (ifexp) ? op2 : op1);
-
 return fold (build3 (COND_EXPR, result_type, ifexp, op1, op2));
}


Well, I did what you asked (remove the prototypes, and so on).
Bootstraped and regtested without regressions on
i686-unknown-linux-gnu.

Is this version OK for commit?

Roger asked me to review this, indicating that he was happy with the fold-const.c changes. I think the c-typeck.c change is fine, as it merely defers to fold to do its proper job. Gabor, please go ahead and commit, after waiting 24 hours to allow a C front end maintainer to complain about the c-ctypeck.c change. Or, if a C front end maintainer has already said that change is OK, just go ahead and commit.


Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]