This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libstdc++] Protect thread tests with #ifdef __GTHREADS
- From: Paolo Carlini <pcarlini at suse dot de>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 05 May 2005 01:54:29 +0200
- Subject: Re: [PATCH, libstdc++] Protect thread tests with #ifdef __GTHREADS
- References: <200505041425.j44EP2029938@makai.watson.ibm.com> <4278E16D.8030305@suse.de> <200505042025.j44KPV031504@makai.watson.ibm.com>
David Edelsohn wrote:
> A number of libstdc++ testcases are failing on AIX because the
>testcases reference specializations that only are present when __GTHREADS
>is defined. This patch protects the tests with #ifdef __GTHREADS so that
>they compile and run when __GTHREADS is not defined.
>
>Okay for mainline?
>
>
In the light of Benjamin's comment, I'm not convinced that this is the
best fix (indeed, would work)... or you already figured out privately
with Benjamin additional details that I'm missing? In that case ok with
me, otherwise, please help me understanding *why* on AIX we are running
those tests in the first place.
Paolo.