This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -fno-unit-at-a-time broken


> On Mon, Apr 25, 2005 at 05:34:40PM -0700, Richard Henderson wrote:
> > Some recent change has broken -fno-unit-at-a-time on mainline.
> > Which, I'll remind folks, is *still* the default at -O1.
> > 
> > Test case:
> > 
> > static inline void foo(void) { }
> > void (*bar) (void);
> > void baz(void) { bar = foo; }
> > 
> > We're no longer emitting foo out of line.
> 
> Honza, this is caused directly by 
> 
> 2005-04-09  Jan Hubicka  <jh@suse.cz>
> 
>         Forgotten hunk from my last merge patch:
>         * final.c (output_addr_const): Do not call mark_referenced.
> 
> I've reverted this patch.  You can look into what else what might
> have been suppsed to accompany this, but as-is, this is clearly wrong.

The idea was to analyze variables same way as we do for unit-at-a-time,
but apparently I messed up the merge somehow.  I will take a look.

Thanks,
Honza
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]