This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR 20994

From: Devang Patel <dpatel at apple dot com>
To: Diego Novillo <dnovillo at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 21 Apr 2005 09:42:12 -0700
Subject: Re: [PATCH] PR 20994
References: <5BF51EFB-4047-42D1-9DAF-AC19130710A7@apple.com> <20050421162854.GA11105@topo.toronto.redhat.com>

On Apr 21, 2005, at 9:28 AM, Diego Novillo wrote:

On Thu, Apr 21, 2005 at 09:06:40AM -0700, Devang Patel wrote:

! tmp_cond = second_bb->aux; ! if (TREE_CODE (tmp_cond) == TRUTH_NOT_EXPR) ! { ! /* Select non loop header condition but do not swith bb. */
s/swith/switch/ ?

yes

Better use caps when referencing local variables and arguments in
comments.  Other than that, the patch looks fine.

OK. Thanks.

-
Devang

References:
- [PATCH] PR 20994
  - From: Devang Patel
- Re: [PATCH] PR 20994
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]