This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING^2 for vectorization and toplevel patches
- From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- To: Roger Sayle <roger at eyesopen dot com>, Janis Johnson <janis187 at us dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 21 Apr 2005 16:30:01 +0200
- Subject: Re: PING^2 for vectorization and toplevel patches
- References: <Pine.LNX.4.44.0504210814120.15848-100000@www.eyesopen.com>
This is also OK for mainline, provided that you keep your
promise (to Joseph Myers) to eventually add the documentation
for UNITS_PER_SIMD_WORD. Normally, the documentation changes
would/should be submitted along with the patch and approved
together.
Yes (I did not do that at once, because UNITS_PER_SIMD_WORD is not
introduced by my patch).
http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00748.html
For this patch, there appear to be a number of comments that
haven't yet been addressed. For example, renaming the functions
to begin with vect_, new documentation describing the new
transformations (in passes.texi?), an perhaps changes to your
new testcases to support the recent generic vectorization changes
to the test suite. Could you retest and repost with those
requested tweaks?
There are no changes in the test cases. I will address your concerns
and repost after I have sorted out with Janis the change in vect.exp.
Thanks,
Paolo