This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch [RFC] fix for an -msse2 failure


On Apr 13, 2005, at 10:55 AM, Roger Sayle wrote:


On Wed, 13 Apr 2005, Fariborz Jahanian wrote:
--- 1951,1957 ----
if (trueop0 == trueop1
&& ! side_effects_p (op0)
&& GET_MODE_CLASS (mode) != MODE_CC)
! return !VECTOR_MODE_P (mode) ? const0_rtx : CONST0_RTX (mode);

/* Canonicalize XOR of the most significant bit to PLUS. */
if ((GET_CODE (op1) == CONST_INT 

I think its best/simpler to use CONST0_RTX even for non vector modes,
i.e. just "return CONST0_RTX (mode);".  Unfortunately, I need to see
the proposed ChangeLog entry before I can pre-approve this change.

Sure. OK if testing went well.

- Thanks, fariborz (fjahanian@apple.com)

ChangeLog:

2005-04-13 Fariborz Jahanian <fjahanian@apple.com>

        * simplify-rtx.c (simplify_binary_operation_1): Return
        scalar or vector of constant 0, depending on the xor's
        mode.

Attachment: fsf-patch-4085599.txt
Description: Text document




Roger
--

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]