This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [4.0 PATCH] Fix PR 20927

From: Richard Sandiford <rsandifo at redhat dot com>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: rth at redhat dot com, mark at codesourcery dot com, gcc-patches at gcc dot gnu dot org, aj at suse dot de
Date: Mon, 11 Apr 2005 23:32:48 +0100
Subject: Re: [4.0 PATCH] Fix PR 20927
References: <200504112211.j3BMBvt7002324@53v30g15.boeblingen.de.ibm.com><878y3p0wz7.fsf@firetop.home>

Richard Sandiford <rsandifo@redhat.com> writes:
> Ulrich Weigand <uweigand@de.ibm.com> writes:
>> As real fix, I think the computation of a "needed mode" may be
>> completely superfluous in the first place; instead, the first
>> clause of the 'if' could just be replaced by
>>
>>   if ((GET_MODE_SIZE (GET_MODE (last_reg))
>>        >= GET_MODE_SIZE (mode) + byte)
>
> I remember wondering about this too.  Unfortunately, there are no
> comments at all explaining what the check is actually supposed to
> do, or what "need_mode" is suppsoed to be, so I thought at the time
> it was best to leave things be.

In case it wasn't clear: that was supposed to be a comment in favour
or your suggested change. ;)

Richard

References:
- [4.0 PATCH] Fix PR 20927 (was: PR19683: Fix a use of REG_CANNOT_CHANGE_MODE_P)
  - From: Ulrich Weigand
- Re: [4.0 PATCH] Fix PR 20927
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]