This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Revert controversial apply_{args,result}_size change
> It would be, and I have no preference (other than that the current
> definition makes no sense if you look at it). My change was originally
> just going to be for apply_args_size, and does match the definition
> there - I just took it across to the similar function.
>
> it appears that the change to apply_result_size was not necessary at all.
>
It appears to be more necessary than I thought at the time, especially
since the two definitions of similar functions are so different.
> I'm, therefore, now of the opinion that reverting the change to
> apply_result_size (and only apply_result_size) is the best solution.
>
For 4.0 perhaps, but that's a generic code change. For mainline I
definitely disagree.
> [Note that I haven't installed any SPARC back-end changes as of this writing,
> I'm waiting for your approval. The patch is only linked to from the Wiki.
> Note also that my change is only a workaround, I certainly don't want to
> modify SPARC's FUNCTION_VALUE_REGNO_P at this point.]
>
I'll work on this for mainline, for 4.0 your patch to sparc.md is
probably fine.
-eric