This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: tree profiling merge: removal of variables whose references was optimized out
- From: Jan Hubicka <jh at suse dot cz>
- To: James E Wilson <wilson at specifixinc dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 8 Apr 2005 12:49:55 +0200
- Subject: Re: tree profiling merge: removal of variables whose references was optimized out
- References: <20050328225809.GX31388@kam.mff.cuni.cz> <4254B7B4.1080503@specifixinc.com>
> Jan Hubicka wrote:
> > * cgraph.c (cgraph_varpool_node_name): New function.
> > (dump_cgraph_varpool_node): New function.
> > (dump_varpool): New function.
> > * cgraphunit.c (cgraph_optimize): Dump varpool.
> >...
>
> This patch was incompletely and/or incorrectly checked in.
>
> The patch removes a hunk of code in final.c, but this code is still in
> mainline. There could be other problems with this patch.
>
> You really need to audit your patch and your checkin, to make sure you
> checked in the correct patch, and that the ChangeLog entry matches what
> you checked in.
>
> I've also noted this problem in PR 20717, in comment #3.
Hi,
I am going to commit this forgotten hunk of the patch,
bootstrapped®tested i686-linux. I am doing tree-profiling merge now
too, so I will check the diff if there is anything else, but it seems to
be fine otherwise.
The change should be perfect noop if everything is working right now
after fix to cgraphunit wrt FDESC.
Honza
*** final.c Sat Apr 2 21:20:03 2005
--- /aux/hubicka/profiling/gcc/gcc/final.c Sat Apr 2 22:43:08 2005
*************** output_addr_const (FILE *file, rtx x)
*** 3170,3177 ****
break;
case SYMBOL_REF:
- if (SYMBOL_REF_DECL (x))
- mark_decl_referenced (SYMBOL_REF_DECL (x));
#ifdef ASM_OUTPUT_SYMBOL_REF
ASM_OUTPUT_SYMBOL_REF (file, x);
#else
--- 3175,3180 ----