This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Second version Re: [RFA:] testsuite/target-supports.exp: check_effective_target_fpic
On Wed, Apr 06, 2005 at 03:27:37AM +0200, Hans-Peter Nilsson wrote:
> > Date: Wed, 6 Apr 2005 03:22:41 +0200
> > From: Hans-Peter Nilsson <hp@axis.com>
>
> > *************** proc check_profiling_available { test_wh
> > *** 295,300 ****
> > --- 303,356 ----
> > return $profiling_available_saved
> > }
> >
> > + # Return 1 if -fpic and -fPIC are supported, as in no warnings or errors
> > + # emitted, 0 otherwise. Whether a shared library can actually be built is
> > + # out of scope for this test.
> > + #
> > + # When the target name changes, replace the cached result.
> > +
> > + proc check_effective_target_fpic { } {
> > + global et_fpic_saved
>
> Please consider a "global et_fpic_target_name" added here.
> Didn't I mention I can't test the
> name-changing-unsets-cached-result support?
Yes, you did mention that. What you've got looks fine. Daniel can let
you know (or fix it himself) if there's a problem with his new target.
Janis