Re: Patch to skip some more tests for x86 -m64

[Mark Mitchell <mark at codesourcery dot com>]

Joseph S. Myers wrote:
> On Sat, 2 Apr 2005, Mark Mitchell wrote:
>
>
> > Andreas Jaeger wrote:
> >
> >
> > > > { dg-require-effective-target ilp32 }
> >
> > I too think that is current accepted best practice.  (It may be that the tests
> > are just skipped on a system which uses -m64 by default; I'm not sure if it
> > actually appends -m32 to run them that way.  However, that's still probably
> > OK; what you really want on such a system is to test with
> > --target_board=unix{-m32,-m64} so that you test both compilation modes, and
> > the test only needs to be run in one of the modes.)
>
>
> I'll prepare a revised patch using { dg-require-effective-target ilp32 } 
> for those tests which should simply be skipped in 64-bit mode (leaving 
> those which should run in both modes but with special options only for 
> 32-bit x86 using { target { i?86-*-* && ilp32 } } in place of the present 
> { target i?86-*-* } on the dg-options line).

That makes sense.

> In principle all the x86 and x86_64 tests should operate on both i?86 and 
> x86_64, with dg-require-effective-target so they only run in the right 
> multilib mode.  Perhaps we need "x86", "x86_ilp32" and "x86_lp64" target 
> keywords to make this simple to specify? 

Yes, that does seem that it would be helpful.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304