This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp] Parser for OpenMP directives
- From: Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>
- To: Richard Henderson <rth at redhat dot com>, Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 29 Mar 2005 09:20:33 +0400
- Subject: Re: [gomp] Parser for OpenMP directives
- References: <c5742c205032500345bf44b40@mail.gmail.com> <20050328215427.GA23445@redhat.com>
- Reply-to: Dmitry Kurochkin <dmitry dot kurochkin at gmail dot com>
> First, please use the -p option to (cvs) diff so that its easier to
> see the context of the patch.
Ok.
> Second, as far as I can see, the threadprivate directive should be
> handled exactly like we currently handle pragma weak. I don't see
> what this pragma has to do with starting a declspec. Similarly wrt
> c_parser_declaration_or_fndef.
We can't handle it like pragma weak because of macro expansion. If we
register threadprivate in omp namespace (like now actually) the macro
expansion will take place only after threadprivate token, not after
omp. So we'll have to register one big handler for pragma omp in
global namespace.
> > + case PRAGMA_OMP_CLAUSE_IF:
> > + c_parser_pragma_omp_clause_if (the_parser);
> > + break;
>
> You'll need to diagnose clases that aren't allowed to be repeated.
> Perhaps that's easier to do once you have an actual data structure
> that you can record things in...
Yes, here we need to create a structure...