Re: Convert libiberty to use ISO C prototype style 3/n

[Gabriel Dos Reis <gdr at integrable-solutions dot net>]

Andreas Jaeger <aj@suse.de> writes:

| Andreas Jaeger <aj@suse.de> writes:
| 
| > I know get tons of warnings in libiberty like the following:
| > /cvs/gcc/libiberty/cp-demangle.c:2609: warning: traditional C rejects ISO C styl
| > e function definitions
| >
| > I propose to remove the "-Wtraditional -pedantic" flags from the
| > CFLAGS, they are currently set in configure.ac:
| >
| >   ac_libiberty_warn_cflags='-W -Wall -Wtraditional -pedantic'
| >
| > Here's a patch.  I'm currently testing on x86-64-linux-gnu.  Ok to
| > commit if bootstrap passes?
| 
| I just noticed that we use in the gcc subdir itself -pedantic.  Is this patch ok
| with just the removal of -Wtraditional?

I think it is a logical part of the conversion and there OK.  But, you
might want to hear from DJ before that.

| We could even add some more warn flags but that's some others should
| look into,

Agreed.

-- Gaby