This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] patch PR 15332 colon edit descriptor ignored
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: François-Xavier Coudert <Francois-Xavier dot Coudert at lcp dot u-psud dot fr>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 25 Mar 2005 02:23:13 +0100
- Subject: Re: [gfortran] patch PR 15332 colon edit descriptor ignored
- References: <42435A08.6010305@lcp.u-psud.fr>
François-Xavier Coudert wrote:
> In fact, we simply ignored the colon edit descriptor because we didn't
> associate any repeat property to it (f->repeat was -1). With the low
> level of debugging available in libgfortran/io routines, it took me two
> hours to figure out. So first, independant question: am I welcome to add
> some more debugging code (that outputs debugging information) in the CVS
> tree, protected by "#if 0 ... #endif" ?
There's already dump_format in format.c, it wouldn't have printed the
information you would have needed, though.
Better debugging aids would certainly be a good thing to have on the mainline.
I think #if ENABLE_CHECKING is more appropriate, iff we can prevent namespace
pollution, i.e. if we can prevent that the names of debug routines interfere
with user code.
> 2005-03-25 Francois-Xavier Coudert <coudert@clipper.ens.fr>
>
> * io/format.c (parse_format_list): format node for colon edit
> descriptor needs a repeat counter set to 1.
>
>
> 2005-03-25 Francois-Xavier Coudert <coudert@clipper.ens.fr>
>
> * gfortran.dg/pr15332.f: New test.
This is ok.
Thanks,
- Tobi