This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Speedup IMA by speeding up comp_types
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 24 Mar 2005 14:48:06 -0800
- Subject: Re: [PATCH] Speedup IMA by speeding up comp_types
- References: <26638b11b9dbbe2e943b3bae948e3d25@physics.uc.edu>
The patch is mostly OK, except that:
- The 'val' field needs to be documented.
- The documentation and name of the tagged_tu_seen structure needs to
be changed to explain that it's now used as a cache.
- alloc_tagged_tu_seen needs to be changed to explain why it's safe to
assume that tu->val should be set to 1 (this is where the former
documentation for tagged_tu_seen should go).