This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Run V3 tests on installed compiler
I consider the social part of this issue completely resolved. (And quite
nicely resolved to boot: we should all pat ourselves on the back for
being mature and resolving this quickly with the minimum of fuss.) The
following is just feedback to Mark on his maintainer style. Hopefully it
is useful.
> | I can
> | certainly remember to wait 24 hours in future, but I'm not sure how
> | everyone else will know.
>
> well, that is not the first time people would send ping messages to
> the list, if it ever happens that your patch is unnoticed...
It seems unlikely that this patch would have not been reviewed. However,
if it was, with GWP and clearly given notice, I would not have had a
problem with this patch being checked in after the time deadline
expired.
We have peer review for a reason.... GWP means you have the ability to
check in anywhere. Not that you should check in without consulting area
maintainers. That's what I mean when I say professional courtesy, but
perhaps my view of things is actually not reflective of reality.
> For example, I was impressed by how careful Zack was in getting V3
> people review/comment on changes he made recently. I think I remember
> similar actions from other maintainers with GWP.
Agreed: Zack did a great job. Also: Jason and the static_mutex bits, RTH
and the uncaught_exception work, etc etc.
-benjamin