This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ Patch] PR 20461, PR 20536
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>,Nathan Sidwell <nathan at codesourcery dot com>
- Date: Mon, 21 Mar 2005 10:22:53 +0100
- Subject: Re: [C++ Patch] PR 20461, PR 20536
- References: <423D5308.7030301@suse.de> <423E2718.6050201@codesourcery.com>
Mark Mitchell wrote:
I wouldn't check TYPE_BINFO here; it's an implementation detail. I
think !COMPLETE_TYPE_P would be better. Also, please add a comment
indicating that we will already have issued an error message by this
point about the fact that the type is incomplete. (As otherwise we
should call complete_type to instantiate templates.)
Thanks Mark for the reviews: indeed, yesterday I noticed in a patch from
Dorit that we have COMPLETE_TYPE_P and seemed much more suited! I will
also add the comment.
Paolo.