This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] TARGET_MEM_REF
Hello,
> > > > * tree.h (REF_ORIGINAL): Expect TARGET_MEM_REF as an argument.
> > > > (MEM_REF_SYMBOL, MEM_REF_BASE, MEM_REF_INDEX, MEM_REF_STEP,
> > > > MEM_REF_OFFSET, build5): New macros.
> > >
> > > These macros should match the name of the tree (IE
> > > TARGET_MEM_REF_SYMBOL, etc).
> > >
> > > Not the least because they conflict directly with the new tree macros
> > > for MEM_REF.
> >
> > I thought you were going to change the name? Frankly, MEM_REF is way
> > too generic name for what your MEM_REFs do,
>
> How so?
> It is a generic memory referencing operation.
INDIRECT_REF is a generic memory referencing operation. Your MEM_REFs
definitely have some additional properties, or you would not
introduce them.
> Anyway, it doesn't change the fact that your macros should match the
> code name.
Of course.
Zdenek