This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: redirect_jump_1: fix REG_EQUAL notes
- From: amylaar at spamcop dot net
- To: amylaar at spamcop dot net
- Cc: Roger Sayle <roger at eyesopen dot com>, gcc-patches at gcc dot gnu dot org, joern dot rennecke at st dot com
- Date: Tue, 1 Mar 2005 23:34:35 -0500
- Subject: Re: RFA: redirect_jump_1: fix REG_EQUAL notes
- References: <20050301225026.4gssc8ccs800w4cs@webmail.spamcop.net>
> And I still disapprove of this idiom:
>
> > {
> >! redirect_exp_1 (&XEXP (note, 0), olabel, nlabel, jump);
> >! apply_change_group ();
> > }
P.S.: If the unnecessary calls to insn_invalid_p are what you are worried about,
my patch for PR rtl-optimization/20070:
http://gcc.gnu.org/ml/gcc-patches/2005-02/msg01062.html
splits apply_change_group basically into two functions, verify_changes and
confirm_change_group. With this infrastructure, the call to apply_change_group
above could be replaced with a call to confirm_change_group.