This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR debug/20161

From: Mark Mitchell <mark at codesourcery dot com>
To: Steven Bosscher <stevenb at suse dot de>
Cc: Daniel Berlin <dberlin at dberlin dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 01 Mar 2005 14:38:11 -0800
Subject: Re: [PATCH] PR debug/20161
Organization: CodeSourcery, LLC
References: <200502250725.12167.stevenb@suse.de> <1109333998.29845.1.camel@linux.site> <3779465.1109339155111.SLOX.WebMail.wwwrun@extimap.suse.de>

Steven Bosscher wrote:

On Feb 25, 2005 01:19 PM, Daniel Berlin <dberlin@dberlin.org> wrote:

Wouldn't it be much easier and more robust to not call any of the
debug_hooks from toplev/final if error_count > 0, then it is to try to
add checks for error_mark_node all over the debug writers?

Yes, but I don't know what other effects that might have
down the road.  This seemed safer for 4.0.

I agree; skipping the debug hooks makes more sense. Even for 4.0. (We're protected by the fact that we'll give the "bailing out" message if that were to somehow cause us to ICE again.)

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]