This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups

From: Julian Brown <julian at codesourcery dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: Daniel Jacobowitz <drow at false dot org>, Nathan Sidwell <nathan at codesourcery dot com>,Andrew Pinski <pinskia at physics dot uc dot edu>, gcc-patches at gcc dot gnu dot org
Date: Mon, 28 Feb 2005 16:38:56 +0000
Subject: Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
References: <421E5EA5.10504@codesourcery.com> <421E628D.9030207@codesourcery.com> <421F7460.4090100@codesourcery.com> <d295a0545822e25f10a211e9bd4e52c2@physics.uc.edu> <20050227172909.GB6586@nevyn.them.org> <42220B7D.5020504@codesourcery.com> <20050227205228.GA10565@nevyn.them.org> <422345AF.8010304@codesourcery.com>

Mark Mitchell wrote:

Daniel Jacobowitz wrote:
Why isn't a::f in a COMDAT group, anyway?

>>

I agree that a::f should be in a COMDAT group, and that this is the root problem. The C++ ABI requires a::f to be COMDAT. I expect that if this problem is fixed, and the missing annotation is added to libjava, that Julian's patch will be OK.

Reverting the patch is the right thing for now.

Julian, do you think you can work out why the inline function isn't being placed in a COMDAT group? (It's apparently being marked weak explicitly, rather than going through the more generic machinery.) If it's not obvious with a little looking, please let me know, and I'll fix it. Then you can retest your patch.

Sure, I will take a look at it!

Cheers,

Julian

--
Julian Brown
CodeSourcery, LLC

References:
- [PATCH] Don't use weak linkage for symbols in COMDAT groups [csl-arm-branch]
  - From: Julian Brown
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups [csl-arm-branch]
  - From: Mark Mitchell
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Julian Brown
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Andrew Pinski
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Daniel Jacobowitz
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Nathan Sidwell
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Daniel Jacobowitz
- Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]