This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] PATCH ping*5 darwin undefined references to _environ


Peter O'Gorman wrote:

Toon,
Thank you for applying this patch to mainline, it does need to be applied to the release branch too though.

Yes, you are right. Paul Brook reminded me that it is a mistake to not apply the same fixes to the 4.0 branch as to mainline, as that will generated confusion in the least and probably real errors.


I'll take care of it.

There is a typo in my email address in the ChangeLog, peter@pogma.com will get to me, peter@pogman.com most certainly will not.

Will fix.


And a question, adding your name and email address to the ChangeLog entry is curious as you did not modify the patch at all, did you? The GNU coding standards would seem to indicate that you should not add your name to the ChangeLog in that case. It is possible (likely?) that gcc has different rules for ChangeLog entries and I am simply unaware of them though.

Hmmm, it could well have been covered by the rules to *not* do it. However, the reason I added my name was because I wanted to take responsibility for this change. If after half a year someone comes around and asks on the Fortran list why their code has gone, I can find back why I deleted it.


--
Toon Moene - e-mail: toon@moene.indiv.nluug.nl - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
Maintainer, GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
A maintainer of GNU Fortran 95: http://gcc.gnu.org/fortran/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]