This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] do_line() crash
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Devang Patel <dpatel at apple dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 27 Feb 2005 12:11:39 -0800
- Subject: Re: [PATCH] do_line() crash
- References: <C743834C-897F-4E8E-8043-D4C2F1896C71@apple.com>
Devang Patel <dpatel@apple.com> writes:
> It is possible that skip_rest_of_line() may cause line tables to be
> reallocated and hence memory access crash later on by accessing old
> pointer. This was reported by one of the customer and it requires huge
> preprocessed source to trigger this.
>
> Radar 3982899
> * directives.c (do_line): Save sysp early before line table is
> realloc'ed.
>
> Bootstrapped and tested on powerpc-darwin.
>
> Geoff has OK'ed this for mainline.
> OK for 4.0 also?
It isn't strictly a regression, but it can't possibly hurt, so yes, go
ahead and apply to 4.0 branch.
zw