This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] do_line() crash


Devang Patel <dpatel@apple.com> writes:

> It is possible that skip_rest_of_line() may cause line tables to be
> reallocated and hence memory access crash later on by accessing old
> pointer. This was reported by one of the customer and it requires huge
> preprocessed source to trigger this.
>
>         Radar 3982899
>         * directives.c (do_line): Save sysp early before line table is
>           realloc'ed.
>
> Bootstrapped and tested on powerpc-darwin.
>
> Geoff has OK'ed this for mainline.
> OK for 4.0 also?

It isn't strictly a regression, but it can't possibly hurt, so yes, go
ahead and apply to 4.0 branch.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]