This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gfortran] PATCH ping*5 darwin undefined references to _environ
- From: Peter O'Gorman <peter at pogma dot com>
- To: Toon Moene <toon at moene dot indiv dot nluug dot nl>
- Cc: gcc-patches at gcc dot gnu dot org, gfortran <fortran at gcc dot gnu dot org>, Steven Bosscher <stevenb at suse dot de>
- Date: Mon, 28 Feb 2005 00:13:19 +0900
- Subject: Re: [gfortran] PATCH ping*5 darwin undefined references to _environ
- References: <421F3CD2.5090203@pogma.com> <42208DC2.8080200@pogma.com>
Peter O'Gorman wrote:
This bug is a regression and the patch should be applied to both
mainline and the gcc-4.0 branch.
Is this patch okay?
Toon,
Thank you for applying this patch to mainline, it does need to be applied to
the release branch too though.
The reasons are:
1) This is a regression, g77 works, gfortran does not work without this patch.
2) This bug was filed 5 months ago and patches were posted here. But the
ball was repeatedly dropped on it.
3) I'll cry if gfortran in gcc-4.0 can not build shared libraries on darwin
without having to specify extra flags (-flat_namespace).
4) is a repeat of 1). This is a regression.
Perhaps someone else needs to elaborate that this is okay for the 4.0
branch, so I beg of all you someone else's to do so.
Also,
There is a typo in my email address in the ChangeLog, peter@pogma.com will
get to me, peter@pogman.com most certainly will not.
And a question, adding your name and email address to the ChangeLog entry is
curious as you did not modify the patch at all, did you? The GNU coding
standards would seem to indicate that you should not add your name to the
ChangeLog in that case. It is possible (likely?) that gcc has different
rules for ChangeLog entries and I am simply unaware of them though.
Thanks,
Peter
--
Peter O'Gorman - http://www.pogma.com